[
https://issues.apache.org/jira/browse/METRON-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476526#comment-16476526
]
ASF GitHub Bot commented on METRON-1565:
----------------------------------------
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/1017
METRON-1565: Metaalerts fix denormalization after moving to active status
## Contributor Comments
I did exactly what the Jira description suggested. Added a test case as
well. I did have to adjust the document comparison logic in the integration
test to ignore child alert order.
I have verified this in full dev. Steps to reproduce are also in the Jira
description:
- Metaalert is updated to inactive
- (Former) child alert is updated
- Metaalert is made active again
- Verify the child alert in the metaalert has the update applied
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1565
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1017.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1017
----
commit 8fb62f198188ea219437c35f7c31fc190120a89b
Author: merrimanr <merrimanr@...>
Date: 2018-05-15T21:45:23Z
initial commit
----
> Metaalerts fix denormalization after moving to active status
> ------------------------------------------------------------
>
> Key: METRON-1565
> URL: https://issues.apache.org/jira/browse/METRON-1565
> Project: Metron
> Issue Type: Bug
> Reporter: Ryan Merriman
> Assignee: Ryan Merriman
> Priority: Major
>
> The process of updating from inactive to active is slightly incomplete. Check
> out
> [https://github.com/apache/metron/pull/970/files#diff-b7359d01c3ffbed48b7fdaa2d32169e7R246].
> Say we have these three steps:
> - Metaalert is updated to inactive
> - (Former) child alert is updated.
> - Metaalert is made active again.
> The update will be missing from the metaalert. We need to update the
> metaalert with the current state of any alerts (which we conveniently have
> because we needed to update them all anyway!). This is a problem with both ES
> and Solr (which shouldn't be surprising since that link is to the abstract
> DAO). Basically, this should just be adding all the alerts in the metaalert
> back into the updated version of the document before passing it to the
> update. It also needs an associated test case.
> This fix should be made against master and pulled into the Solr branch (and
> the metaalerts PR afterwards). See
> [https://github.com/apache/metron/blob/e59059bd9707a6ca46c4137d796b8f2943f06b43/metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java#L351].
> Main thing might just be reordering the class to build the metaalert update
> itself after grabbing all the alerts.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
