[
https://issues.apache.org/jira/browse/METRON-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16485742#comment-16485742
]
ASF GitHub Bot commented on METRON-1572:
----------------------------------------
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1024
METRON-1572 Enhance KAFKA_PUT function
Note: This PR is built on the shoulders of #1023. To review the change
specific to this PR, review the changes made in the second commit or wait until
#1023 is merged.
### Changes
* Enhances the KAFKA_PUT function to accept either a list of strings or a
string. This makes it simpler to send either 1 message or a bunch of messages.
* KAFKA_PUT should queue up all messages to be sent before waiting on a
response. This improves response time when sending a large number of messages.
## Pull Request Checklist
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1572
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1024.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1024
----
commit 10fe2bfd04db6633b73e9d0f37d458f4ce83aaf9
Author: Nick Allen <nick@...>
Date: 2018-04-20T20:18:16Z
METRON-1571
commit 75e9f39fe55c07cd149f00e26c0ec1de760e2d9a
Author: Nick Allen <nick@...>
Date: 2018-05-22T23:17:09Z
METRON-1572 Enhance KAFKA_PUT function
----
> Enhance KAFKA_PUT function
> --------------------------
>
> Key: METRON-1572
> URL: https://issues.apache.org/jira/browse/METRON-1572
> Project: Metron
> Issue Type: Improvement
> Reporter: Nick Allen
> Assignee: Nick Allen
> Priority: Major
>
> Enhance the KAFKA_PUT function to accept either a List of String or a String.
> This makes it simpler to send either 1 message or a bunch of messages.
> KAFKA_PUT should queue up all messages to be sent before waiting on a
> response. This improves response when sending a large number of messages.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
