GitHub user as22323 opened a pull request:
https://github.com/apache/metron/pull/1032
METRON-1578 - EC2 10 Node Deployment - Reverting to using control_path with
%C for Mac
## Contributor Comments
A description of the problem:
This PR is to revert to the previous control_path in ansible.cfg that is
compatible with Mac OS (ansible-ssh-%%C). This corrects an issue due to [PR
754](https://github.com/apache/metron/pull/754) that was submitted on Sept
2017.
This PR also updates the "Error" section of the ec2 README.md to include a
solution to the error "percent_expand: unknown key %C" that may occur with
certain Linux distributions.
Testing was done on Mac OS High Sierra using "master" code from 2018-05-23.
However the error that was thrown might not be to due to the control_path issue
since ambari_* TASKs were succeeding.
"TASK [python-pip : Install Python's pip Centos ] ... FAILED.. you need to
be root to perform this command.."
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
"master" code from 2018-05-23
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
Reproduce Bug:
1) if ansible.cfg has "control_path = ~/.ssh/ansbile-ssh-%%h-%%r"
2) ./run.sh
3) "ssh throws unix domain socket too long" error is thrown
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
1) update ansible.cfg with "control_path = ~/.ssh/ansible-ssh-%%C"
2) ./run.sh
3) see if install tasks are succeeding (i.e. TASK [httplib2 : Install ....
])
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtemp1/metron master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1032.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1032
----
commit 03271a99ee3644e8f539bcdd955ba7c4d5568120
Author: as22323 <a.k.shah@...>
Date: 2018-05-25T07:11:35Z
ec2 readme - included desc. for error with %C
commit a6cf8a8c74389f9fc731474a6afb8dc6c9ddadee
Author: as22323 <a.k.shah@...>
Date: 2018-05-25T07:13:12Z
commented *-%%h-%%r, uncommented *-ssh-%%C
----
---
