[
https://issues.apache.org/jira/browse/METRON-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491060#comment-16491060
]
ASF GitHub Bot commented on METRON-1580:
----------------------------------------
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1034
METRON-1580 Release candidate check script requires Bro Plugin
Not all Metron releases will include a new version of the Bro Plugin. The
release candidate script currently requires it though. These changes make the
`--bro` argument option which allows us to validate releases which do not
contain an updated Bro plugin.
## Testing
```
./dev-utilities/release-utils/metron-rc-check --version=0.5.0
--candidate=RC1
```
## Pull Request Checklist
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1580
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1034.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1034
----
commit 2e8283d1bb2372128bc077f7253f67180890f875
Author: Nick Allen <nick@...>
Date: 2018-05-25T17:35:58Z
METRON-1580 Release candidate check script requires Bro Plugin
----
> Release candidate check script requires Bro Plugin
> --------------------------------------------------
>
> Key: METRON-1580
> URL: https://issues.apache.org/jira/browse/METRON-1580
> Project: Metron
> Issue Type: Improvement
> Affects Versions: 0.4.2
> Reporter: Nick Allen
> Assignee: Nick Allen
> Priority: Major
>
> Not all Metron releases will include a new version of the Bro Plugin. The
> release candidate script currently requires it though.
>
> {code:java}
> $ ./dev-utilities/release-utils/metron-rc-check --version=0.5.0
> --candidate=RC1
> Missing -b/--bro which is required
> $ ./dev-utilities/release-utils/metron-rc-check --version=0.5.0
> --candidate=RC1 --bro=0.1.0
> Metron Version 0.5.0
> Release Candidate rc1
> Bro Plugin Version 0.1.0
> Metron RC Distribution Root is
> https://dist.apache.org/repos/dist/dev/metron/0.5.0-RC1
> Working directory /Users/nallen/tmp/metron-0.5.0-rc1
> Downloading https://dist.apache.org/repos/dist/dev/metron/0.5.0-RC1/KEYS
> --2018-05-25 13:33:53--
> https://dist.apache.org/repos/dist/dev/metron/0.5.0-RC1/KEYS
> Resolving dist.apache.org (dist.apache.org)... 209.188.14.144
> Connecting to dist.apache.org (dist.apache.org)|209.188.14.144|:443...
> connected.
> HTTP request sent, awaiting response... 200 OK
> Length: 64954 (63K) [text/plain]
> Saving to: ‘/Users/nallen/tmp/metron-0.5.0-rc1/KEYS’
> KEYS
> 100%[=========================================================================================================================================================================>]
> 63.43K --.-KB/s in 0.1s
> 2018-05-25 13:33:54 (469 KB/s) - ‘/Users/nallen/tmp/metron-0.5.0-rc1/KEYS’
> saved [64954/64954]
> Downloading
> https://dist.apache.org/repos/dist/dev/metron/0.5.0-RC1/apache-metron-0.5.0-rc1.tar.gz
> --2018-05-25 13:33:54--
> https://dist.apache.org/repos/dist/dev/metron/0.5.0-RC1/apache-metron-0.5.0-rc1.tar.gz
> Resolving dist.apache.org (dist.apache.org)... 209.188.14.144
> Connecting to dist.apache.org (dist.apache.org)|209.188.14.144|:443...
> connected.
> HTTP request sent, awaiting response... 200 OK
> Length: 8357400 (8.0M) [application/octet-stream]
> Saving to: ‘/Users/nallen/tmp/metron-0.5.0-rc1/apache-metron-0.5.0-rc1.tar.gz’
> apache-metron-0.5.0-rc1.tar.gz
> 100%[=========================================================================================================================================================================>]
> 7.97M 3.08MB/s in 2.6s
> 2018-05-25 13:33:57 (3.08 MB/s) -
> ‘/Users/nallen/tmp/metron-0.5.0-rc1/apache-metron-0.5.0-rc1.tar.gz’ saved
> [8357400/8357400]
> Downloading
> https://dist.apache.org/repos/dist/dev/metron/0.5.0-RC1/apache-metron-0.5.0-rc1.tar.gz.asc
> --2018-05-25 13:33:57--
> https://dist.apache.org/repos/dist/dev/metron/0.5.0-RC1/apache-metron-0.5.0-rc1.tar.gz.asc
> Resolving dist.apache.org (dist.apache.org)... 209.188.14.144
> Connecting to dist.apache.org (dist.apache.org)|209.188.14.144|:443...
> connected.
> HTTP request sent, awaiting response... 200 OK
> Length: 833 [text/plain]
> Saving to:
> ‘/Users/nallen/tmp/metron-0.5.0-rc1/apache-metron-0.5.0-rc1.tar.gz.asc’
> apache-metron-0.5.0-rc1.tar.gz.asc
> 100%[=========================================================================================================================================================================>]
> 833 --.-KB/s in 0s
> 2018-05-25 13:33:57 (12.0 MB/s) -
> ‘/Users/nallen/tmp/metron-0.5.0-rc1/apache-metron-0.5.0-rc1.tar.gz.asc’ saved
> [833/833]
> Downloading
> https://dist.apache.org/repos/dist/dev/metron/0.5.0-RC1/apache-metron-bro-plugin-kafka_0.1.0.tar.gz
> --2018-05-25 13:33:57--
> https://dist.apache.org/repos/dist/dev/metron/0.5.0-RC1/apache-metron-bro-plugin-kafka_0.1.0.tar.gz
> Resolving dist.apache.org (dist.apache.org)... 209.188.14.144
> Connecting to dist.apache.org (dist.apache.org)|209.188.14.144|:443...
> connected.
> HTTP request sent, awaiting response... 404 Not Found
> 2018-05-25 13:33:58 ERROR 404: Not Found.
> [ERROR] Failed to download
> https://dist.apache.org/repos/dist/dev/metron/0.5.0-RC1/apache-metron-bro-plugin-kafka_0.1.0.tar.gz{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
