[ 
https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492065#comment-16492065
 ] 

ASF GitHub Bot commented on METRON-1579:
----------------------------------------

Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1033#discussion_r191080813
  
    --- Diff: 
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/BaseStellarProcessor.java
 ---
    @@ -143,7 +143,11 @@ public T parse(final String rule, final 
VariableResolver variableResolver, final
         try {
           return clazz.cast(expression
               .apply(new StellarCompiler.ExpressionState(context, 
functionResolver, variableResolver)));
    -    }finally {
    +    }
    --- End diff --
    
    Maybe we can have stellar exception builders that provide standard, 
consistent exception building


> Stellar should return the expression that failed in the exception
> -----------------------------------------------------------------
>
>                 Key: METRON-1579
>                 URL: https://issues.apache.org/jira/browse/METRON-1579
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Casey Stella
>            Priority: Major
>
> There are situations where we are not including the expression in the 
> exception. Also, in stellar enrichments, we should include the relevant 
> variable values in the exception to help with diagnosing issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to