Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1033#discussion_r191080813
  
    --- Diff: 
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/BaseStellarProcessor.java
 ---
    @@ -143,7 +143,11 @@ public T parse(final String rule, final 
VariableResolver variableResolver, final
         try {
           return clazz.cast(expression
               .apply(new StellarCompiler.ExpressionState(context, 
functionResolver, variableResolver)));
    -    }finally {
    +    }
    --- End diff --
    
    Maybe we can have stellar exception builders that provide standard, 
consistent exception building


---

Reply via email to