[
https://issues.apache.org/jira/browse/METRON-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500823#comment-16500823
]
ASF GitHub Bot commented on METRON-1589:
----------------------------------------
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1040#discussion_r192870707
--- Diff:
metron-platform/metron-solr/src/main/java/org/apache/metron/solr/writer/SolrWriter.java
---
@@ -17,47 +17,46 @@
*/
package org.apache.metron.solr.writer;
+import static org.apache.metron.solr.SolrConstants.SOLR_WRITER_NAME;
+
import com.google.common.base.Joiner;
+import java.io.IOException;
+import java.io.Serializable;
+import java.lang.invoke.MethodHandles;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.UUID;
+import java.util.function.Supplier;
import org.apache.commons.lang3.StringUtils;
import org.apache.metron.common.Constants;
+import org.apache.metron.common.configuration.writer.WriterConfiguration;
+import org.apache.metron.common.writer.BulkMessageWriter;
+import org.apache.metron.common.writer.BulkWriterResponse;
+import org.apache.metron.solr.SolrConstants;
import org.apache.metron.stellar.common.utils.ConversionUtils;
+import org.apache.solr.client.solrj.SolrServerException;
import org.apache.solr.client.solrj.impl.HttpClientUtil;
import org.apache.solr.client.solrj.impl.HttpSolrClient;
import org.apache.solr.client.solrj.impl.Krb5HttpClientConfigurer;
+import org.apache.solr.client.solrj.response.UpdateResponse;
import org.apache.solr.common.SolrException;
+import org.apache.solr.common.SolrInputDocument;
import org.apache.storm.task.TopologyContext;
import org.apache.storm.tuple.Tuple;
-import org.apache.metron.common.configuration.writer.WriterConfiguration;
-import org.apache.metron.common.writer.BulkMessageWriter;
-import org.apache.metron.common.writer.BulkWriterResponse;
-import org.apache.solr.client.solrj.SolrServerException;
-import org.apache.solr.client.solrj.response.UpdateResponse;
-import org.apache.solr.common.SolrInputDocument;
import org.json.simple.JSONObject;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import java.io.IOException;
-import java.io.Serializable;
-import java.lang.invoke.MethodHandles;
-import java.util.HashMap;
-import java.util.Map;
-import java.util.Collection;
-import java.util.Optional;
-import java.util.List;
-import java.util.ArrayList;
-import java.util.Set;
-import java.util.UUID;
-import java.util.function.Supplier;
-
-import static org.apache.metron.solr.SolrConstants.SOLR_WRITER_NAME;
-
public class SolrWriter implements BulkMessageWriter<JSONObject>,
Serializable {
public static final String JAVA_SECURITY_CONFIG_PROPERTY =
"java.security.auth.login.config";
public enum SolrProperties {
- ZOOKEEPER_QUORUM("solr.zookeeper"),
+ ZOOKEEPER_QUORUM(SolrConstants.SOLR_ZOOKEEPER),
--- End diff --
Yep, this is fine. +1 by inspection.
> '/api/v1/search/search' fails when 'Solr Zookeeper Urls' has comma separated
> multiple zookeeper urls
> ----------------------------------------------------------------------------------------------------
>
> Key: METRON-1589
> URL: https://issues.apache.org/jira/browse/METRON-1589
> Project: Metron
> Issue Type: Sub-task
> Reporter: Justin Leet
> Assignee: Justin Leet
> Priority: Major
>
> http://metronnode:8082/api/v1/search/search with below payload fails with
> internal server error when 'Solr Zookeeper Urls' has comma separated multiple
> zookeeper urls
> {code:java}
> {
> "indices": [],
> "facetFields": [],
> "query": "*",
> "from": 0,
> "size": 25
> }
> {code}
> {code:java}
> {"responseCode":500,"message":"Cannot connect to cluster at
> ctr-e138-1518143905142-328005-01-000006.hwx.site:2181/solr,ctr-e138-1518143905142-328005-01-000005.hwx.site:2181/solr:
> cluster not found/not ready","fullMessage":"SolrException: Cannot connect to
> cluster at
> ctr-e138-1518143905142-328005-01-000006.hwx.site:2181/solr,ctr-e138-1518143905142-328005-01-000005.hwx.site:2181/solr:
> cluster not found/not ready"}
> {code}
>
> This appears to result from here
> [SolrDao.java#L137-L144|https://github.com/apache/metron/blob/feature/METRON-1416-upgrade-solr/metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrDao.java#L137-L144]
> In `getSolrClient`, `withZkHost` should be called multiple times after
> splitting the comma delimited string, per
> [CloudSolrClient.Builder#withZkHost|https://lucene.apache.org/solr/6_5_0/solr-solrj/org/apache/solr/client/solrj/impl/CloudSolrClient.Builder.html#withZkHost-java.lang.String-].
> Overall, this could probably be done a couple ways, either to just split the
> String directly, or rearrange the methods to pass around Lists and have
> `getZkHost` be changed to `getZkHosts` and take care of it in a more
> contained manner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
