[
https://issues.apache.org/jira/browse/METRON-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500828#comment-16500828
]
ASF GitHub Bot commented on METRON-1601:
----------------------------------------
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/1049
METRON-1601: Rename metaalert "alert" nested field to "metron_alert" to
avoid collision
## Contributor Comments
Currently we add a nested field called "alert" to our ES templates to
enable meta alert querying. This field name is too common and should be
something like "metron_alert" instead.
To test this, spin up full-dev and add a meta alert via the alerts UI. You
should be able to interact with it via the alerts UI as normal.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron
alert_to_metron_alert
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1049.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1049
----
commit 01c33f1bef5349f6896d1dcd4bd37f0d332bdaef
Author: cstella <cestella@...>
Date: 2018-05-29T18:15:56Z
Renaming alert to metron_alert
commit 2afe4377a80b9d8a451551bcbb9a98edfb09e00e
Author: cstella <cestella@...>
Date: 2018-05-29T18:22:42Z
Updating readme.
commit 78be5089de44da1b452401a44fba1e25f960b1ea
Author: cstella <cestella@...>
Date: 2018-05-29T20:03:39Z
updated test
commit 4f98acc9afcfb7ef5a42a2b9ba716ce43e927753
Author: cstella <cestella@...>
Date: 2018-05-29T20:41:50Z
Updating test.
commit ebb3b6f950d125257a7105e2a2c3a71f4c978e10
Author: cstella <cestella@...>
Date: 2018-05-29T21:19:50Z
Updating test.
commit 449d3f8aca422fb8b924de9e7b2106360c5813c6
Author: cstella <cestella@...>
Date: 2018-05-29T22:06:00Z
changed the test dao
commit d72a3f1cbb27cf38b2463eef0cc356e7ee4b040e
Author: cstella <cestella@...>
Date: 2018-05-29T23:18:23Z
updating alert model.
commit 8aeba1f419f273a53a4a4636c21ebe46a0b242ae
Author: cstella <cestella@...>
Date: 2018-05-29T23:29:27Z
Missed the details component.
commit 34c31f01b4ad585036b060f4f030bc52486f2209
Author: cstella <cestella@...>
Date: 2018-05-29T23:37:23Z
updating components
commit 71adb72ece3674339d8d6d555771a0dd78f1767b
Author: cstella <cestella@...>
Date: 2018-06-04T17:59:35Z
Merge branch 'master' into alert_to_metron_alert
commit d14b0f2b9dfd2c3af2de18b67641d2192a619d0c
Author: cstella <cestella@...>
Date: 2018-06-04T20:26:38Z
updating the table view component.
----
> Rename metaalert "alert" nested field to "metron_alert" to avoid collision
> --------------------------------------------------------------------------
>
> Key: METRON-1601
> URL: https://issues.apache.org/jira/browse/METRON-1601
> Project: Metron
> Issue Type: Improvement
> Reporter: Casey Stella
> Priority: Major
>
> Currently we add a nested field called "alert" to our ES templates to enable
> meta alert querying. This field name is too common and should be something
> like "metron_alert" instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
