GitHub user sardell reopened a pull request:
https://github.com/apache/metron/pull/1004
METRON-1489: Retrofit UI tests to run reliably
## Contributor Comments
This Pull Request includes work started by @iraghumitra on his branch
`e2e-using-await-1`. In addition to the asyn/await work he did, I added
[protractor-flake](https://github.com/NickTomlin/protractor-flake) in order to
re-run failing tests to ensure they are actual failures and not the result of
flakey tests.
In order to test locally, be sure to install protractor-flake before
running the e2e tests. This is done by running `npm install` inside of the
metron-alerts directory.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sardell/metron METRON-1489
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1004.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1004
----
commit 08ba22a35b4b6a741e504c3c59ccd98889f4ec7e
Author: iraghumitra <raghumitra.ksv@...>
Date: 2018-04-26T09:07:57Z
Initial commit for e2e tests in new branch
commit 1daefda4b8d39dc24d8cc44bc837efa7bd6734e0
Author: Shane Ardell <sardell@...>
Date: 2018-04-27T10:49:25Z
METRON-1489: fix test to account for leap year days
commit 92542ad6607e8d84aa312c5c14175adb07573481
Author: Shane Ardell <sardell@...>
Date: 2018-04-27T11:06:16Z
METRON-1489: fix flakey test results with protractor-flake
commit e7e71875cccb8781595a6ca687174483bca462a0
Author: Shane Ardell <sardell@...>
Date: 2018-05-03T09:16:53Z
add protractor option to run headless
commit 54f417d06bfd1ed69d2c7a2e29f5cbc765cc480f
Author: Shane Ardell <sardell@...>
Date: 2018-05-03T11:00:55Z
uncomment tests and assertions that now pass
commit 19876cb48d85920b22052938cd216a59ac55f833
Author: Shane Ardell <sardell@...>
Date: 2018-05-03T11:33:00Z
remove outdated code
commit 877c05a8b889b105989b0f0eeca08f8935f9c9ef
Author: Shane Ardell <sardell@...>
Date: 2018-05-03T11:34:47Z
add workaround for ssh2 auth failure
commit 0343ed1c8955062d511b3dcc4cf6a3414deef07b
Author: Shane Ardell <sardell@...>
Date: 2018-05-11T16:37:59Z
cleanup commented out code
commit 47748bc1c7d4119610d0e519af86e2f4f340255a
Author: Shane Ardell <sardell@...>
Date: 2018-05-14T14:19:55Z
fix e2e section formatting and typos in alerts documentation
commit a9650ed28b534ab6547e8d99356be81f87730c4c
Author: Shane Ardell <sardell@...>
Date: 2018-05-14T14:40:57Z
uncomment timestamp test in custom date save test
commit b47737ebf99ea90bdb51bfc45fec9d3372bb4158
Author: Shane Ardell <sardell@...>
Date: 2018-05-14T15:46:39Z
remove commented out lines from alerts-list test functions
commit 4fc0d99b63f8383d28cadecb7525731015a98304
Author: Shane Ardell <sardell@...>
Date: 2018-05-16T08:45:03Z
remove unused code from protractor config
commit 5fb88e82e89accc24767b5e014e905b63db73fba
Author: Shane Ardell <sardell@...>
Date: 2018-06-05T12:08:46Z
add async/await and cleanup alert-details e2e tests
commit d4227187165e2c89e894835843b08bafa345673a
Author: Shane Ardell <sardell@...>
Date: 2018-06-05T12:51:03Z
uncomment all test files
commit d02d4d6293e6dd25cb585808f158cd670a5f17b9
Author: Shane Ardell <sardell@...>
Date: 2018-06-05T12:52:13Z
cleanup clickOnRow function
commit 03631aa5149e5532efe082f87d4da9f5472c1003
Author: Shane Ardell <sardell@...>
Date: 2018-06-05T12:54:27Z
disable only comment tests that rely on getText()
----
---
