GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/1051
METRON-1603: Fix multivalue field errors in Bro Solr schema
## Contributor Comments
https://issues.apache.org/jira/browse/METRON-1603
Ran some sample from our unit testing infrastructure that pointed out some
shortcomings in the Bro schema not revealed by our standard sensor-stub data
that's setup by default as a service for demo purposes in full dev. For Bro
records that have multi-valued fields (i.e. an array of values), you will see
an exception when indexing in Solr if the collection does not explicitly set
multiValued=true for that field.
I modified the Solr schema check integration test data to flex all of the
multi-valued fields I found properly.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)? - this is pertinent to the Solr upgrade feature
branch.
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
n/a
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/metron fix-schema-multivalued
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1051.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1051
----
commit 692a888e00ccedf900aa176ed35ec9d187875ab0
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-06-04T21:44:41Z
METRON-1603: Fix multivalue field errors in Bro Solr schema
----
---
