[ 
https://issues.apache.org/jira/browse/METRON-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509995#comment-16509995
 ] 

ASF GitHub Bot commented on METRON-1616:
----------------------------------------

GitHub user merrimanr opened a pull request:

    https://github.com/apache/metron/pull/1061

    METRON-1616: Changing alert status fails if no metaalerts have been created 
yet

    ## Contributor Comments
    This PR fixes a small bug where alert updates will fail if the metaalerts 
index hasn't been created yet.  This is because the metaalert DAO layer 
attempts to lookup any metaalerts that may contain the alert and update them.  
The solution presented here catches this case and safely continues with the 
update.
    
    This has been tested in full dev.  Navigate to the alerts UI, click on an 
alert to open the alerts details panel, and change the status.  There should be 
no errors and the status should be updated successfully.
    
    I added a couple unit tests to cover this.  I looked at adding an 
integration tests but currently our setup creates the metaalerts index.  It's 
probably more trouble than it's worth to create a new (or significantly modify 
the existing) integration test specifically for this case.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merrimanr/incubator-metron METRON-1616

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1061.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1061
    
----
commit 36826d38a19ea89e5343c096221a16fd2f3938ea
Author: merrimanr <merrimanr@...>
Date:   2018-06-12T18:21:06Z

    initial commit

----


> Changing alert status fails if no metaalerts have been created yet
> ------------------------------------------------------------------
>
>                 Key: METRON-1616
>                 URL: https://issues.apache.org/jira/browse/METRON-1616
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Ryan Merriman
>            Priority: Major
>
> Patching an alert will fail with a IndexNotFoundException if a metaalert 
> hasn't been created yet and the metaalert index doesn't exist.  This is 
> because the ElasticsearchMetaAlertDao tries to lookup and update any 
> metaalerts that contain the alert.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to