[
https://issues.apache.org/jira/browse/METRON-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522652#comment-16522652
]
ASF GitHub Bot commented on METRON-1634:
----------------------------------------
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1077
What happens in the case where two comments are optimistically added, then
the first one fails?
e.g.
1. User adds comment_1
2. User adds comment_2
3. Some failure occurs and comment_1 fails, but comment_2 succeeds.
I'd expect the state of this to be just comment_2. Since the UI stores the
previousComments, does this get overwritten by adding comment_2? In this case,
and correct me if I'm wrong, the comments will be reset to the UI's belief of
the previous version (comment_1) and therefore out of sync with the store until
the comments are reloaded.
Admittedly, I'd expect this to be pretty rare (and require the user to
rapidly add a couple comments)
> Alerts UI add comment doesn't immediately show up.
> --------------------------------------------------
>
> Key: METRON-1634
> URL: https://issues.apache.org/jira/browse/METRON-1634
> Project: Metron
> Issue Type: Bug
> Reporter: Ryan Merriman
> Priority: Major
>
> For ES (and potentially Solr), when the Alerts UI adds a comment to an alert,
> it calls the update, then immediately calls a findOne to retrieve it. This
> comment might not immediately be available, so it doesn't show the new
> comment.
> Instead of running a findOne, assuming the update responds appropriately, we
> should probably just add it directly in the UI.
> Also applies to removing a comment
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
