GitHub user tiborm reopened a pull request: https://github.com/apache/metron/pull/1085
METRON-1636: Fix broken unit test setup in metron-alerts ## Contributor Comments I made changes in the unit tests of the metron-alert UI to make test runnable. All the dependencies of the tested components, directives, and pipes were mocked out or included to avoid runtime errors. I also unified the naming of the tests. I also removed Router from table-view.component and tree-view.component because it was just injected as an unused dependency which also has had to be mocked out in the tests otherwise. This change was checked and manually tested with caution to avoid any regression. ### Steps to run Unit Test in metron-alert: 1. clone repo 2. go to metron-interface/metron-alert/ 3. run: npm install 4. run: npm test ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` #### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tiborm/metron METRON-1636 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1085.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1085 ---- commit dd408e94af3b8a20e07a4f3fd32c1028489ee6c0 Author: tiborm <tibor.meller@...> Date: 2018-06-27T15:22:37Z METRON-1636: adding coverage foldre to gitignor commit 12e2de392e61cecbb363f6598ef8d7a7081f444e Author: tiborm <tibor.meller@...> Date: 2018-06-27T15:23:04Z METRON-1636: including text-summary to coverage report commit 8249ff410593050ebfa83763d2765993114086b1 Author: tiborm <tibor.meller@...> Date: 2018-06-27T15:27:59Z METRON-1636: cutting down or include dependecies, unifying naming ---- ---