Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1082#discussion_r199607708
  
    --- Diff: 
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/kafka/KafkaWriter.java
 ---
    @@ -197,6 +209,15 @@ public void init(Map stormConf, TopologyContext 
topologyContext, WriterConfigura
         return producerConfig;
       }
     
    +  public Optional<String> getKafkaTopic(JSONObject message) {
    --- End diff --
    
    What if we unset the value of the topic field after the redirect occurs?  
This would force the user to set the field again, if they really want another 
redirect.
    
    It seems like on day 1 of a user attempting to use this functionality, they 
are going to fall into this trap.  To really use this functionality, you need 
to set the value in one step and then unset or change it in the next step.  If 
you don't, its going to loop.
    



---

Reply via email to