[
https://issues.apache.org/jira/browse/METRON-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531465#comment-16531465
]
ASF GitHub Bot commented on METRON-1653:
----------------------------------------
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/1093
METRON-1653: Stellar exceptions can be extremely nested and we should make
efforts to separate the nested exception better
## Contributor Comments
Stellar exceptions can be extremely nested and we should make efforts to
separate the nested exception better. What happens now is sometimes the
exception gets cut off.
This one should be able to be tested in the REPL. Just do something that
causes an exception and ensure that an error is logged with the inner-most
exception in addition to the ParseException that contains the innermost
exception.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron
stellar_exception_logging_part_2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1093.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1093
----
commit a21ed3adf123abd29401119290048e59a051803c
Author: cstella <cestella@...>
Date: 2018-07-03T14:10:43Z
Better logging for nested exceptions.
----
> Stellar exceptions can be extremely nested and we should make efforts to
> separate the nested exception better
> -------------------------------------------------------------------------------------------------------------
>
> Key: METRON-1653
> URL: https://issues.apache.org/jira/browse/METRON-1653
> Project: Metron
> Issue Type: Improvement
> Reporter: Casey Stella
> Priority: Major
>
> Stellar exceptions can be extremely nested and we should make efforts to
> separate the nested exception better. What happens now is sometimes the
> exception gets cut off.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
