Github user ottobackwards commented on the issue:

    https://github.com/apache/metron/pull/1091
  
    @jameslamb,
    
    The vagrant stuff is the general information on how to run it.  For the 
docker containers that you have worked on, it would be fine I think to say that 
you tested that the containers work for their purpose.
    
    It would be enough for you to say in the description:
    
    ```
    Testing:
    run ansible docker like this %THIS, see that it works without error
    run deb docker like this %THIS, see that it works without error
    run rpm docker like this %THIS, see that it works without error
    
    ```
    
    Our vagrant build for centos and ubuntu targets actually use the rpm and 
deb dockers so that is one way they get tests, but doesn't have to be the only 
way.
    
    the ansible docker must be tested explicitly
    
    



---

Reply via email to