Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1099#discussion_r201349285
  
    --- Diff: 
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/ParserTopologyBuilder.java
 ---
    @@ -91,14 +101,14 @@ public Config getTopologyConfig() {
        */
       public static ParserTopology build(String zookeeperUrl,
                                           Optional<String> brokerUrl,
    -                                      String sensorType,
    -                                      ValueSupplier<Integer> 
spoutParallelismSupplier,
    -                                      ValueSupplier<Integer> 
spoutNumTasksSupplier,
    +                                      List<String> sensorTypes,
    +                                      ValueSupplier<List> 
spoutParallelismSupplier,
    --- End diff --
    
    This is a nit, but is there any reason why we couldn't make these 
`ValueSupplier<List<Integer>>` and `ValueSupplier<List<Map>>`? 


---

Reply via email to