Github user mmiklavc commented on the issue:

    https://github.com/apache/metron/pull/1103
  
    @tiborm Thanks for the contribution! A few comments for starters:
    - Can you provide a test script for reviewers?
    - What's this 10k+ line spec file? Are these working AngularJS unit tests, 
and if so, are they now part of the build? Please comment, and if they are not 
part of the automated build, please provide instructions for running them even 
if it's simply pointing to an existing doc.
    - When you have run through the items in the PR checklist from above, 
please mark them as such.


---

Reply via email to