Github user rgasiorek commented on a diff in the pull request:
https://github.com/apache/metron/pull/1104#discussion_r202558931
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/DateFunctionsTest.java
---
@@ -182,7 +182,8 @@ public void testDayOfMonthNull() {
@Test
public void testWeekOfYear() {
Object result = run("WEEK_OF_YEAR(epoch)");
- assertEquals(35, result);
+ calendar.setTimeInMillis(AUG2016);
--- End diff --
it it save to morph/mutate an object that is shared? What about a short
lived object like that:
@Test
public void testWeekOfYear() {
Object result = run("WEEK_OF_YEAR(epoch)");
- assertEquals(35, result);
+ Calendar testCalendar = Calendar.getInstance();
+ testCalendar.setTimeInMillis(AUG2016);
+ assertEquals(testCalendar.get(Calendar.WEEK_OF_YEAR), result);
}
---
