[ 
https://issues.apache.org/jira/browse/METRON-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545683#comment-16545683
 ] 

ASF GitHub Bot commented on METRON-1657:
----------------------------------------

Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1099#discussion_r202805243
  
    --- Diff: metron-platform/metron-parsers/README.md ---
    @@ -82,6 +82,12 @@ topology in kafka.  Errors are collected with the 
context of the error
     (e.g. stacktrace) and original message causing the error and sent to an
     `error` queue.  Invalid messages as determined by global validation
     functions are also treated as errors and sent to an `error` queue. 
    +
    +Multiple sensors can be aggregated into a single Storm topology. When this 
is done, there will be
    +multiple Kafka spouts, but only a single parser bolt which will handle 
delegating to the correct 
    --- End diff --
    
    Essentially the flow in the syslog case is:
    
    1. Syslog message comes in through the wrapper's topic.
    2. The spout for syslog passes it through to the aggregate bolt.
    3. The aggregated bolt does its job unwrapping and outputs the inner 
messages to the appropriate topics for each.
    4. The spouts for the inner messages then pick up from the now populated 
topics.
    5. All spouts are now passing messages as they receive them to the 
aggregate bolt.
    6. All messages get delegated and handled as needed.
    
    This implementation doesn't do anything clever around avoiding output 
topics if the aggregate parser is already contained here.


> Parser aggregation in storm
> ---------------------------
>
>                 Key: METRON-1657
>                 URL: https://issues.apache.org/jira/browse/METRON-1657
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Justin Leet
>            Assignee: Justin Leet
>            Priority: Major
>
> Currently our parsing solution requires one storm topology per sensor. It has 
> been complained that this may be wasteful of resources and that, rather than 
> one storm topology per sensor, it would be advantageous to have multiple 
> sensors in the same topology. The benefit to this is that it would require 
> fewer storm slots.
> The issue with this is that whenever we've aggregated functionality like this 
> before, we've run into issues appropriately being able to scale storm (e.g. 
> batch vs random access indexing in the same topology).  The main point in 
> addressing this is to recommend that parsers with similar velocities and 
> complexity are grouped together.
> Particularly for a first cut, leave the configuration mostly as-is, while 
> allowing for comma separated lists of sensors in start_parser_topology.sh 
> (e.g. bro,yaf creates a aggregated parser consisting of those two). 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to