[ 
https://issues.apache.org/jira/browse/METRON-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546952#comment-16546952
 ] 

ASF GitHub Bot commented on METRON-1614:
----------------------------------------

Github user mmiklavc commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1108#discussion_r203121809
  
    --- Diff: 
metron-platform/metron-common/src/main/java/org/apache/metron/common/utils/HDFSUtils.java
 ---
    @@ -29,6 +29,16 @@
     
     public class HDFSUtils {
     
    +  public static byte[] readBytes(String path) throws IOException {
    +    return readBytes(new Path(path));
    +  }
    +
    +  public static byte[] readBytes(Path inPath) throws IOException {
    +    FileSystem fs = FileSystem.get(inPath.toUri(), new Configuration());
    +    FSDataInputStream inputStream = fs.open(inPath);
    --- End diff --
    
    I found 2 such dangling input streams and am supplying a fix for both.


> Create job status abstraction
> -----------------------------
>
>                 Key: METRON-1614
>                 URL: https://issues.apache.org/jira/browse/METRON-1614
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Ryan Merriman
>            Assignee: Michael Miklavcic
>            Priority: Major
>
> It is possible to use different job engines such as MR or Spark. There should 
> be an abstraction that allows us to track status independent of the 
> underlying job engine. Initially we will use YARN/MR to run pcap query jobs. 
> We will also need a way to persist this information.
> Pcap job submission should be asynchronous. Some kind of id should be 
> returned upon successful job submission rather than blocking and waiting on 
> the job to complete.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to