[
https://issues.apache.org/jira/browse/METRON-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553325#comment-16553325
]
ASF GitHub Bot commented on METRON-1671:
----------------------------------------
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1103
I have a couple comments after spinning up #1122 (which should have all
these changes, I believe).
- Better input validation would be nice. I can currently enter negative
ports (which don't match anything) or ports beyond max int (which match
everything!). Ideally this would also happen in the REST layer, because it
kicks off jobs that have nonsense parameters.
- The UI doesn't appear to allow users to kill jobs (although the REST API
exists for it). Is it correct that this isn't supported?
- The parameters differ if you've never entered a field vs. entered then
deleted it. For example, for ports (and possibly just the two port fields),
it'll be empty string if never entered and null if entered then deleted. This
appears to be benign, although surprising.
- Kicking off a job, then navigating to the alerts view, then navigating
back allows a user to kick off a second job. I'm not sure what happens when as
these jobs finish in potentially either order (or any order if you repeat this
and kick off many jobs).
- The UI polls for job status infinitely if the REST UI dies.
- It's odd that the port fields have increment / decrement buttons. I would
expect a user to manually enter that every time.
- I get an NPE if there are no pcaps within the date range provided by the
query. This is a backend query thing, so it might be worth creating a separate
ticket for it?
> Create PCAP UI
> --------------
>
> Key: METRON-1671
> URL: https://issues.apache.org/jira/browse/METRON-1671
> Project: Metron
> Issue Type: Sub-task
> Reporter: Tibor Meller
> Priority: Major
>
> The initial feature set of PCAP UI is the follwing:
> - Filtering by
> - IP Source Address
> - IP Source Port
> - IP Dest Address
> - IP Dest Port
> - Protocol
> - Include Reverse Traffic
> - Free text filtering
> - Showing PDML result
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
