GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/1128
METRON-1690: Add more context to PcapJob JobStatus
## Contributor Comments
https://issues.apache.org/jira/browse/METRON-1690
Adds more context for failure scenarios to the JobStatus object returned by
PcapJob. Removes duplication between Timer status updates and the getStatus
call.
## Pull Request Checklist
Follow test plan from the following:Â
https://github.com/apache/metron/pull/1109
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/metron pcap-job-status
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1128
----
commit 92b0503eef5b3cc41c4b7b99cc8db173715172e2
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-07-20T18:20:11Z
Create copy constructor for JobStatus
commit 414ef1015f0d834a174e09557680f2563b15264b
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-07-24T02:48:42Z
Provide more context around error conditions.
commit 497e54b71bac94cace9e7ac5d0af982a45366336
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-07-24T03:10:29Z
Update diagrams
----
---
