[ 
https://issues.apache.org/jira/browse/METRON-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556183#comment-16556183
 ] 

ASF GitHub Bot commented on METRON-1695:
----------------------------------------

Github user anandsubbu commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1132#discussion_r205237418
  
    --- Diff: 
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/parser_master.py
 ---
    @@ -54,6 +57,12 @@ def configure(self, env, upgrade_type=None, 
config_dir=None):
                 commands.init_kafka_acls()
                 commands.set_acl_configured()
     
    +        File(format("{metron_config_path}/pcap.properties"),
    --- End diff --
    
    I had earlier place this under the [indexing_master.py 
](https://github.com/apache/metron/blob/master/metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_master.py#L62)script,
 but felt that it is more related to parser than with indexing. I am happy to 
move this block to any other place that is deemed fit.


> Expose pcap properties through Ambari
> -------------------------------------
>
>                 Key: METRON-1695
>                 URL: https://issues.apache.org/jira/browse/METRON-1695
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Anand Subramanian
>            Assignee: Anand Subramanian
>            Priority: Major
>
> Currently, the $METRON_HOME/config/pcap.properties file is hardcoded with the 
> defaults. One has to hand edit the file before deploying the PCAP topology. 
> These properties should be configurable via Ambari.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to