[ 
https://issues.apache.org/jira/browse/METRON-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559736#comment-16559736
 ] 

ASF GitHub Bot commented on METRON-1671:
----------------------------------------

Github user sardell commented on the issue:

    https://github.com/apache/metron/pull/1103
  
    @justinleet In response to your UI-related questions:
    
    > Better input validation would be nice. I can currently enter negative 
ports (which don't match anything) or ports beyond max int (which match 
everything!). Ideally this would also happen in the REST layer, because it 
kicks off jobs that have nonsense parameters.
    
    It looks like @ruffle1986 added some validation [in this 
branch](https://github.com/ruffle1986/metron/commit/1c4bc69eb55d1ba96ce6d101516099d2a788ecf7).
 Are you fine with this being a follow up PR?
    
    > The UI doesn't appear to allow users to kill jobs (although the REST API 
exists for it). Is it correct that this isn't supported?
    
    In the current iteration of the UI, a button to kill jobs is not available. 
I agree that we should add this to the UI, but if it's okay with you I think 
this could be a follow on PR. 
    
    > The parameters differ if you've never entered a field vs. entered then 
deleted it. For example, for ports (and possibly just the two port fields), 
it'll be empty string if never entered and null if entered then deleted. This 
appears to be benign, although surprising.
    
    Nice catch. I think we should open a ticket to investigate this further.
    
    > Kicking off a job, then navigating to the alerts view, then navigating 
back allows a user to kick off a second job. I'm not sure what happens when as 
these jobs finish in potentially either order (or any order if you repeat this 
and kick off many jobs).
    
    If a job is now running, an error is returned from the API. The UI work to 
handle this is in [this 
commit](https://github.com/apache/metron/pull/1122/commits/60f5d76d62f9b23dd44d9890b05c0101ae2b2080).
    
    > It's odd that the port fields have increment / decrement buttons. I would 
expect a user to manually enter that every time.
    
    It looks like this was resolved by @ruffle1986 [in this 
branch](https://github.com/ruffle1986/metron/commit/1c4bc69eb55d1ba96ce6d101516099d2a788ecf7)
 by removing the type attribute on the input.
    
    



> Create PCAP UI
> --------------
>
>                 Key: METRON-1671
>                 URL: https://issues.apache.org/jira/browse/METRON-1671
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Tibor Meller
>            Priority: Major
>
> As a user, I like to submit PCAP query requests from the Metron UI.
> As a user, I like to be able to narrow down the result set of the query by 
> the following filters:
>   - IP Source Address
>   - IP Source Port
>   - IP Dest Address
>   - IP Dest Port
>   - Protocol
>   - Include Reverse Traffic
>   - Free text filtering
> As a user, I like to get feedback from the progress of the ongoing request by 
> a progress bar.
> As a user, I like to see the result of the query in a grid. Each line of the 
> grid should show and extendable packet record.
> As a user, when I clicking on a row of the result grid I would like to see 
> additional information about that particular packet.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to