Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1122
I tested this in full dev and I think it's working well from a functional
perspective.
I do believe the tests are still lacking though. Here are the issues I
found:
- When I run `npm test` I see this:
```
Executed 4 of 63 (skipped 59)
```
Why are tests being skipped? Is it something with my environment?
- It looks like `pcap.service.spec.ts` hasn't been updated in a while
- As far as I can tell, `pcap-panel.component.spec.ts` isn't testing the
onSearch function
- I think we're still missing tests in `pcap-packet.component.spec.ts`
- I see sample data declared as `fakePacket` in some tests. Can we make
this smaller? It seems like this test data is bigger than it needs to be and
redundant. Is there a way to share this across tests?
---
