Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1135#discussion_r206607449
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/PcapServiceImpl.java
---
@@ -199,6 +208,37 @@ public InputStream getRawPcap(String username, String
jobId, Integer page) throw
return inputStream;
}
+ @Override
+ public Map<String, Object> getConfiguration(String username, String
jobId) throws RestException {
+ Map<String, Object> configuration = new HashMap<>();
+ try {
+ Map<String, Object> jobConfiguration = jobManager.getJob(username,
jobId).getConfiguration();
--- End diff --
Will `jobManager.getJob(username, jobId)` never return null? I see null
checks in other places where similar calls are made.
---