[jira] [Commented] (METRON-1700) Create REST endpoint to get job configuration

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/METRON-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564021#comment-16564021
 ] 

ASF GitHub Bot commented on METRON-1700:
----------------------------------------

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1135#discussion_r206611012
  
    --- Diff: 
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/PcapServiceImpl.java
 ---
    @@ -199,6 +208,37 @@ public InputStream getRawPcap(String username, String 
jobId, Integer page) throw
         return inputStream;
       }
     
    +  @Override
    +  public Map<String, Object> getConfiguration(String username, String 
jobId) throws RestException {
    +    Map<String, Object> configuration = new HashMap<>();
    +    try {
    +      Map<String, Object> jobConfiguration = jobManager.getJob(username, 
jobId).getConfiguration();
    +      configuration.put(PcapOptions.BASE_PATH.getKey(), 
PcapOptions.BASE_PATH.get(jobConfiguration, String.class));
    +      configuration.put(PcapOptions.FINAL_OUTPUT_PATH.getKey(), 
PcapOptions.FINAL_OUTPUT_PATH.get(jobConfiguration, String.class));
    +      configuration.put(PcapOptions.START_TIME_MS.getKey(), 
PcapOptions.START_TIME_MS.get(jobConfiguration, String.class));
    +      configuration.put(PcapOptions.END_TIME_MS.getKey(), 
PcapOptions.END_TIME_MS.get(jobConfiguration, String.class));
    +      configuration.put(PcapOptions.NUM_REDUCERS.getKey(), 
PcapOptions.NUM_REDUCERS.get(jobConfiguration, Integer.class));
    +
    +      boolean isFixedFilter = 
PcapOptions.FILTER_IMPL.get(jobConfiguration, PcapFilterConfigurator.class) 
instanceof FixedPcapFilter.Configurator;
    +      if (isFixedFilter) {
    +        configuration.put(FixedPcapOptions.IP_SRC_ADDR.getKey(), 
FixedPcapOptions.IP_SRC_ADDR.get(jobConfiguration, String.class));
    +        configuration.put(FixedPcapOptions.IP_DST_ADDR.getKey(), 
FixedPcapOptions.IP_DST_ADDR.get(jobConfiguration, String.class));
    +        configuration.put(FixedPcapOptions.IP_SRC_PORT.getKey(), 
FixedPcapOptions.IP_SRC_PORT.get(jobConfiguration, String.class));
    +        configuration.put(FixedPcapOptions.IP_DST_PORT.getKey(), 
FixedPcapOptions.IP_DST_PORT.get(jobConfiguration, String.class));
    +        configuration.put(FixedPcapOptions.PROTOCOL.getKey(), 
FixedPcapOptions.PROTOCOL.get(jobConfiguration, String.class));
    +        configuration.put(FixedPcapOptions.PACKET_FILTER.getKey(), 
FixedPcapOptions.PACKET_FILTER.get(jobConfiguration, String.class));
    +        configuration.put(FixedPcapOptions.INCLUDE_REVERSE.getKey(), 
FixedPcapOptions.INCLUDE_REVERSE.get(jobConfiguration, String.class));
    +      } else {
    +        configuration.put(QueryPcapOptions.QUERY.getKey(), 
QueryPcapOptions.QUERY.get(jobConfiguration, String.class));
    +      }
    +    } catch (JobNotFoundException e) {
    +      // do nothing and return null pcapStatus
    --- End diff --
    
    Is this comment correct?  Seems like we return an empty configuration map 
(assuming the call to getJob does not return null).


> Create REST endpoint to get job configuration
> ---------------------------------------------
>
>                 Key: METRON-1700
>                 URL: https://issues.apache.org/jira/browse/METRON-1700
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Ryan Merriman
>            Priority: Major
>
> We need a REST endpoint that will allow us to retrieve the job configuration 
> properties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)