[
https://issues.apache.org/jira/browse/METRON-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571972#comment-16571972
]
ASF GitHub Bot commented on METRON-1705:
----------------------------------------
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1148
METRON-1705 Create ProfilePeriod Using Period ID [Feature Branch]
In some cases you need to be able to create a `ProfilerPeriod` using an
epoch timestamp. In other cases, you need to be able to create one using the
period ID. The period ID is a monotonically increasing value which uniquely
identifies each profile period.
Since both an epoch timestamp and a period ID are `Long`s, I created two
separate factory methods to create a `ProfilePeriod` rather than using a public
constructor directly. This makes it much more clear as to the intended purpose.
* `ProfilePeriod.fromTimestamp`
* `ProfilePeriod.fromPeriodId`
This is a pull request against the `METRON-1699-create-batch-profiler`
feature branch.
## Testing
1. Launch the development environment.
1. Ensure alerts are created in the Alerts UI.
1. Ensure the Service Check in Ambari passes.
1. Follow the instructions in the Profiler README to create a basic profile
in the REPL.
1. Follow the instructions in the Profiler README to create a simple
profile using the Profiler topology in Storm.
## Pull Request Checklist
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1705-v2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1148.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1148
----
commit ce0b629bcaa95bcc450177756f1a95bddeabde8b
Author: Nick Allen <nick@...>
Date: 2018-07-24T18:02:36Z
Need to be able to create a ProfilePeriod using the period identifier
----
> Create ProfilePeriod Using Period ID
> ------------------------------------
>
> Key: METRON-1705
> URL: https://issues.apache.org/jira/browse/METRON-1705
> Project: Metron
> Issue Type: Sub-task
> Reporter: Nick Allen
> Assignee: Nick Allen
> Priority: Major
>
> Need to be able to create a ProfilePeriod using the Period ID.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
