[
https://issues.apache.org/jira/browse/METRON-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572241#comment-16572241
]
ASF GitHub Bot commented on METRON-1728:
----------------------------------------
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/1151
METRON-1728: Handle null values in config in Pcap backend more gracefully
## Contributor Comments
https://issues.apache.org/jira/browse/METRON-1728
I modified the ConfigOptions interface to provide the ability to handle
default values similar to the Map interface. ie getOrDefault. For PcapJob, I
only improved/changed the values we expect to be user-supplied, ie start time,
end time, etc., so we don't throw NPE's if a value gets lost in translation. I
think we should definitely still add some validation to users via both REST and
the UI similar to what is done in PcapCLI.
**Note:** This PR is an improvement to existing functionality, not a
regression fix.
## Pull Request Checklist
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
n/a
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/metron pcap-config-handle-nulls
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1151.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1151
----
commit 1fee540969b2f192e58805cdca1ce0a666759af6
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-08-07T19:29:41Z
Handle null values in config backend more gracefully
----
> Handle null values in config in Pcap backend more gracefully
> ------------------------------------------------------------
>
> Key: METRON-1728
> URL: https://issues.apache.org/jira/browse/METRON-1728
> Project: Metron
> Issue Type: Sub-task
> Reporter: Michael Miklavcic
> Assignee: Michael Miklavcic
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
