GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/1153
METRON-1725: Add ability to specify YARN queue for pcap jobs
## Contributor Comments
This PR exposes a configuration option in the Pcap CLI and REST app for the
YARN queue a pcap job will be submitted to. This configuration is passed on to
the `mapreduce.job.queuename` property in the Hadoop config. A YARN queue is
set in the Pcap CLI with an additional command line option (`-yq`) and is set
in the REST app as a spring property (`pcap.yarn.queue`).
### Testing
This has been tested in full dev:
1. Create a YARN queue named `pcap` using the YARN Queue Manager
2. Ambari should prompt you, but be sure to restart the Resource Manager
3. Submit a job with the Pcap CLI and add the YARN queue option: `-yq pcap`
4. While the job is running navigate to the Resource Manager UI and verify
the job is running in the `pcap` queue
5. Try to submit a job to a queue that doesn't exist. You should get a
clear error stating the queue is missing
6. Go to Ambari > Services > Metron > REST and set the `Metron Spring
options` property to `--pcap.yarn.queue=pcap`.
7. Ambari will prompt you to restart REST
8. Submit a job through the REST app and verify the job is running in the
`pcap` queue
9. Submitting jobs in the Pcap CLI without the `yq` option and submitting
jobs in REST without setting the `pcap.yarn.queue` should submit to the default
queue.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1725
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1153
----
commit bf17024766edc9a48d6c915001775315ba6e3f19
Author: merrimanr <merrimanr@...>
Date: 2018-08-06T22:03:14Z
initial commit
commit c7d9108fcfe5f3ab5a08a55e56e0272cc1dac4a2
Author: merrimanr <merrimanr@...>
Date: 2018-08-08T12:37:49Z
added tests and documentation
----
---
