Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/1157#discussion_r209689930
--- Diff:
metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/mr/PcapJob.java
---
@@ -307,8 +307,11 @@ public void setCompleteCheckInterval(long interval) {
}
return this;
}
- mrJob.submit();
- jobStatus.withState(State.SUBMITTED).withDescription("Job
submitted").withJobId(mrJob.getJobID().toString());
+ synchronized (this) {
--- End diff --
Will do. This lock is about thread visibility as opposed to actual issues
with concurrent modification. It may be that this lock is not need with
getStatus being synchronized. I will double check and report back via modified
code and/or code comment on this.
---
