Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/1165#discussion_r210306465
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.spec.ts
---
@@ -263,10 +230,10 @@ describe('PcapFiltersComponent', () => {
model: new SimpleChange(null, newModel, false)
});
- expect(component.startTimeStr).toBe(startTimeStr);
- expect(component.endTimeStr).toBe(endTimeStr);
- expect(component.ipSrcPort).toBe('');
- expect(component.ipDstPort).toBe('');
+
expect(component.filterForm.controls.startTime.value).toBe(startTimeStr);
+ expect(component.filterForm.controls.endTime.value).toBe(endTimeStr);
+ expect(component.filterForm.controls.ipSrcPort.value).toBe(0);
--- End diff --
Why would we want the ports to be 0 here? This query is incorrect.
---
