[
https://issues.apache.org/jira/browse/METRON-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590666#comment-16590666
]
ASF GitHub Bot commented on METRON-1748:
----------------------------------------
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1174
METRON-1748 Improve Storm Profiler Integration Test
Improved the Storm Profiler integration tests based on improvements I made
for the Spark Profiler feature branch.
* Validate the output of the Profiler using the client library;
`PROFILE_GET`. This is better validation that things are working end-to-end.
* Using more telemetry messages to validate event time processing.
* Added logging around cache maintenence.
* Added logging of the tuple windows that are passed from Storm's
WindowManager. This can help debug issues where the time lag and window size
are incorrectly set.
## Pull Request Checklist
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1748
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1174.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1174
----
commit 56b70f666dd75a2861d17a23b7ed307124ba1f74
Author: Nick Allen <nick@...>
Date: 2018-08-17T17:13:10Z
METRON-1748 Improve Storm Profiler Integration Test
----
> Improve Storm Profiler Integration Test
> ---------------------------------------
>
> Key: METRON-1748
> URL: https://issues.apache.org/jira/browse/METRON-1748
> Project: Metron
> Issue Type: Bug
> Reporter: Nick Allen
> Assignee: Nick Allen
> Priority: Major
>
> We should use the Profiler Client, like PROFILE_GET, to validate the output
> of the Storm Profiler Integration Test. This is better validation that
> things are working end-to-end.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
