Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1175#discussion_r213039514
  
    --- Diff: 
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/syslog/Syslog5424Parser.java
 ---
    @@ -0,0 +1,83 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.metron.parsers.syslog;
    +
    +import com.github.palindromicity.syslog.NilPolicy;
    +import com.github.palindromicity.syslog.SyslogParser;
    +import com.github.palindromicity.syslog.SyslogParserBuilder;
    +import com.github.palindromicity.syslog.dsl.SyslogFieldKeys;
    +import java.util.Collections;
    +import java.util.List;
    +import java.util.Map;
    +import org.apache.metron.parsers.BasicParser;
    +import org.json.simple.JSONObject;
    +
    +
    +
    +/**
    + * Parser for well structured RFC 5424 messages.
    + */
    +public class Syslog5424Parser extends BasicParser {
    +  public static final String NIL_POLICY_CONFIG = "nilPolicy";
    +  /**
    +   * The NilPolicy specifies how the parser handles missing fields in the 
return
    +   * It can:
    +   *  Omit the fields
    +   *  Have a value of '-' ( as spec )
    +   *  Have null values for the fields
    +   * <p>The default is to omit the fields from the return set.</p>
    +   */
    +  private NilPolicy nilPolicy = NilPolicy.OMIT;
    +
    +  @Override
    +  public void configure(Map<String, Object> config) {
    +    String nilPolicyStr = (String) 
config.getOrDefault(NIL_POLICY_CONFIG,NilPolicy.OMIT.name());
    +    nilPolicy = NilPolicy.valueOf(nilPolicyStr);
    +  }
    +
    +  @Override
    +  public void init() {
    +  }
    +
    +  @Override
    +  @SuppressWarnings("unchecked")
    +  public List<JSONObject> parse(byte[] rawMessage) {
    +    try {
    +      if (rawMessage == null || rawMessage.length == 0) {
    +        return null;
    +      }
    +
    +      String originalString = new String(rawMessage);
    +
    +      SyslogParser parser = new 
SyslogParserBuilder().withNilPolicy(nilPolicy).build();
    --- End diff --
    
    I don't think I want to touch all the parsers for this PR , there might be 
more than one parser follow on depending on how many have configurations.  Can 
you create  a jira or shall I?


---

Reply via email to