GitHub user ruffle1986 opened a pull request:
https://github.com/apache/metron/pull/1182
METRON-1760: show a confirmation popover before killing the pcap query
## Contributor Comments
Currently, if we have a running pcap query and we click on the "cancel"
button, the request goes to the server immediately.
Since it could take long, it's very annoying if the user clicks on the
cancel button accidentally when the query is so close to be fulfilled.
In this patch, the user is asked whether she really wants to cancel the
running pcap query by a confirmation popover appearing next to the cancel
button.
FYI: in this PR, I'm introducing a new dependency:
https://github.com/mattlewis92/angular-confirmation-popover#readme
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [X] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [X] Have you included steps or a guide to how the change may be verified
and tested manually?
- [X] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [X] Have you written or updated unit tests and or integration tests to
verify your changes?
- [X] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ruffle1986/metron METRON-1760
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1182.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1182
----
commit b5788fb1f892012d4cd105fc8c23667fd7c8df6f
Author: Shane Ardell <sardell@...>
Date: 2018-06-27T13:08:01Z
update angular to current stable version
commit 4f1ee4fea99cc154ee0a328a349abab58c0d67a2
Author: Shane Ardell <sardell@...>
Date: 2018-07-05T10:45:58Z
remove module file extension
commit cd5942a11c25e8ccb1be98919e3c4883823f2f59
Author: Shane Ardell <sardell@...>
Date: 2018-07-05T11:09:53Z
add http interceptor for default headers
commit fa40b49f9a6d2aa4b36a9266e4b72b28a5c26ecb
Author: Shane Ardell <sardell@...>
Date: 2018-07-05T12:01:16Z
update configurations
commit 86bfaa30c89b24474fbfaed118c3b35c483c19e3
Author: Shane Ardell <sardell@...>
Date: 2018-07-05T12:02:21Z
update dependencies
commit 1abd618b5f2b53381feb23ba12ccb1fa282da297
Author: Shane Ardell <sardell@...>
Date: 2018-07-05T12:03:06Z
update services to use HttpClient and rxjs changes
commit c7e7c95fd84618218b786d8f8ecad3d660434318
Author: Shane Ardell <sardell@...>
Date: 2018-07-05T15:50:24Z
merge master and resolve conflicts in view and login specs
commit d7e93fc6558903aa95d11280bbaf0273d7df10b3
Author: Shane Ardell <sardell@...>
Date: 2018-07-06T11:39:24Z
add line to ignore .vscode folder
commit 7257e2682199736efa3696b7e4cb3fe64bb6461b
Author: Shane Ardell <sardell@...>
Date: 2018-07-06T11:40:12Z
use ReplaySubject instead of EventEmitter in service
commit 38927ae4ab6785d4889a7ca732b948f3bdc9cdf9
Author: Shane Ardell <sardell@...>
Date: 2018-07-06T11:40:59Z
fix import statement for 'of' method
commit 9203a83cd39cf44aa847ea2d6aa265d17c684c28
Author: Shane Ardell <sardell@...>
Date: 2018-07-06T11:59:42Z
remove EventEmitter import
commit b0626bd7d84eeafdce2d83a87d0e3f04e2c6faa5
Author: Shane Ardell <sardell@...>
Date: 2018-07-06T12:12:30Z
update build script
commit 3e7b8597fd1ea4fb6be7d43658bb9f0304e80432
Author: Shane Ardell <sardell@...>
Date: 2018-07-06T12:36:14Z
Merge branch 'master' into METRON-1476
commit 6e1dd103713aa929fdc92dc6177996ebd329930b
Author: Shane Ardell <sardell@...>
Date: 2018-07-06T12:39:24Z
update node and npm version to support Angular 6
commit 952adade6042f095bcfec1d4dad1d1bacc5c959a
Author: Shane Ardell <sardell@...>
Date: 2018-07-06T13:48:27Z
add Apache license to file
commit 21b128a405812530e4b94f17ba48324186000935
Author: Shane Ardell <sardell@...>
Date: 2018-07-06T13:53:04Z
move import statement below license
commit 72ef6ef4ec99d4d6eee50e670cf5bfee5ba7e39d
Author: Shane Ardell <sardell@...>
Date: 2018-07-09T14:56:53Z
add rat.txt output to travis config
commit 6fd857869f3291c73d6c900fd474fe26418708d2
Author: Shane Ardell <sardell@...>
Date: 2018-07-10T10:04:43Z
Merge branch 'master' into METRON-1476
commit 115f046ec852bec674f048048935adc17459dc7c
Author: Shane Ardell <sardell@...>
Date: 2018-07-12T14:12:51Z
add minified dist files to exclude list
commit 7b98ee7978f067b10c9bb931f43e387640138e9a
Author: Shane Ardell <sardell@...>
Date: 2018-07-12T14:13:41Z
remove troubleshooting script
commit e911dc3158b40390a0b322a5e7c9d0ee01bdc3b0
Author: Shane Ardell <sardell@...>
Date: 2018-07-14T12:03:00Z
remove dist files from excludes
commit 1fd77b4cad470b29e9fc308f41b8117fd98f725a
Author: Shane Ardell <sardell@...>
Date: 2018-07-14T12:04:53Z
update license script to include css files
commit 40a992ecb907b08c2bb08b35d507177613004a9f
Author: Shane Ardell <sardell@...>
Date: 2018-07-16T10:01:23Z
add .nvmrc
commit 217b19345ed5c3ce988bc0ebce25317a7ab928d5
Author: Shane Ardell <sardell@...>
Date: 2018-08-22T11:50:53Z
merge master into METRON-1476
Conflicts
both modified: package-lock.json
both modified: package.json
both modified: src/app/app-routing.module.ts
both modified: src/app/app.module.ts
commit 36e5055efb1cd71b7ae2e08846b0c6fef780f5a7
Author: Shane Ardell <sardell@...>
Date: 2018-08-23T18:08:30Z
replace XHRBackend with HttpClientTesting
commit 4defa064a2f151283c6a8e290b361e94b8e8d613
Author: Shane Ardell <sardell@...>
Date: 2018-08-23T18:10:20Z
format file
commit 8b402d32b9ba7d9814924eb39ea1e7c1d785571b
Author: Shane Ardell <sardell@...>
Date: 2018-08-24T08:49:43Z
add missing license
commit 10c66fc8a457af0d2a7cf1d4dd10298410d6f322
Author: Shane Ardell <sardell@...>
Date: 2018-08-24T09:13:19Z
replace repetative injections
commit de58cae2525614f57e06b4f5454c7e283c253371
Author: Shane Ardell <sardell@...>
Date: 2018-08-24T09:53:20Z
add aot flag to pom.xml
commit 0146ff1ddcb795e2271e49ce6c92abe4b33a30c0
Author: Shane Ardell <sardell@...>
Date: 2018-08-24T09:56:33Z
remove unnecessary package lock from root
----
---
