[
https://issues.apache.org/jira/browse/METRON-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603620#comment-16603620
]
ASF GitHub Bot commented on METRON-1756:
----------------------------------------
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/1186
METRON-1756: REST tests should use Embedded LDAP in metron-security
## Contributor Comments
This PR switches authentication from JDBC-based to LDAP in metron-rest.
### Changes Included
- Added test dependencies for metron-ui-security and Apache Directory to
metron-rest
- Removed JDBC authentication (the TestSecurityConfig class)
- Updated the metron-rest integration test to set the
`EMBEDDED_LDAP_PROFILE`
- Added additional users to the LDAP schema as required by metron-rest tests
- Suppressed Apache directory log warnings when running metron-rest tests
### Testing
All metron-rest unit and integration tests should continue to pass.
### Other Considerations
After switching the metron-rest tests to use LDAP through
metron-ui-security, I noticed a significant number of LDAP-related log warnings
when running the integration tests. As far as I can tell they are caused by
missing LDAP attributes and similar issues that we probably don't care about.
I can also see the argument for wanting these logs enabled to make it easier
for future contributors to find and diagnose problems when working on these
tests (although it's easy enough to update the log4j.properties file if
needed). Thoughts?
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1756
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1186.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1186
----
commit 4bcfd594636bf8f8ec924b0b62dd0a08b3c315fb
Author: merrimanr <merrimanr@...>
Date: 2018-08-29T17:05:38Z
initial commit
----
> REST tests should use Embedded LDAP in metron-security
> ------------------------------------------------------
>
> Key: METRON-1756
> URL: https://issues.apache.org/jira/browse/METRON-1756
> Project: Metron
> Issue Type: Sub-task
> Reporter: Ryan Merriman
> Priority: Major
>
> Tests in metron-rest are still using JDBC-based authentication. These tests
> (and all security-related tests) should use the testing infrastructure
> introduced in METRON-1665.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
