GitHub user simonellistonball reopened a pull request:

    https://github.com/apache/metron/pull/1114

    METRON-1667 Remove the JPA and MySQL elements

    ## Contributor Comments
    
    Given that the only use of the JPA elements was for persisting a user 
database, these dependencies are no longer needed, so will be removed to reduce 
the vulnerability surface. 
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/simonellistonball/metron METRON-1667

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1114
    
----
commit eeb7d586ae44d6a2768d3972cd3ff367cd065e50
Author: Simon Elliston Ball <simon@...>
Date:   2018-07-04T11:22:42Z

    Removed plugins for eclipselink since jpa is no longer included

commit 181d38243bfdc4d75b28891a3b06510391c8d4f2
Author: Simon Elliston Ball <simon@...>
Date:   2018-07-12T17:15:16Z

    Removed configs for JPA

commit b3f888e4f95b79e034afd0ff7865f748dcc5b6d3
Author: Simon Elliston Ball <simon@...>
Date:   2018-07-12T17:20:50Z

    Remove JPA elements

commit 2a1cc4ea73419cdb96dc6ee7bdc35daa9c2e5804
Author: Simon Elliston Ball <simon@...>
Date:   2018-07-19T13:46:52Z

    updated dependencies list to reflect removal of JPA

commit 85f7911c05b463a1399d5145ee6f1e860755559c
Author: Simon Elliston Ball <simon@...>
Date:   2018-07-20T10:07:37Z

    Removed bean setup for jdbc authentication

commit 91b09e4ceea196965191eada696f11e6a9792f76
Author: Simon Elliston Ball <simon@...>
Date:   2018-07-20T11:08:58Z

    Added in-memory auth for tests

commit e1e4f4f300160c8cd0e8270c60605cfc528e91c7
Author: Simon Elliston Ball <simon@...>
Date:   2018-07-19T10:04:44Z

    Fixed security test for UI settings

commit 88f83f48d28383cb33eca4e47abd1b830b9b6f5a
Author: Simon Elliston Ball <simon@...>
Date:   2018-07-20T12:59:32Z

    Property placeholder is only needed for SSO and LDAP branch

commit 0fc7b864fe6c03b462c9f13c4a35b45b05a4a551
Author: Simon Elliston Ball <simon@...>
Date:   2018-07-20T15:44:06Z

    Enabled PreAuthorie security for Alerts test fix

commit 54880ba8f2467fefe56b9c377da003d08f0fe203
Author: simonellistonball <simon@...>
Date:   2018-08-28T19:20:10Z

    METRON-1665 Move hosting of Alerts and Config UIs from Nodejs to Spring 
Boot (simonellistonball via merrimanr) closes apache/metron#1111

commit 320de00fac5b9f37590b2962610dd615cba2c5a2
Author: Simon Elliston Ball <simon@...>
Date:   2018-07-04T11:22:42Z

    Removed plugins for eclipselink since jpa is no longer included

commit b88e0400937632ad0c1d0262fab9a44ea92766f6
Author: Simon Elliston Ball <simon@...>
Date:   2018-07-12T17:15:16Z

    Removed configs for JPA

commit 971507bb4f6a5be8647d739b8be9e0470d676bf3
Author: Simon Elliston Ball <simon@...>
Date:   2018-07-12T17:20:50Z

    Remove JPA elements

commit 99e04a1ad066b6fee88b8f7e856563466dea2467
Author: Simon Elliston Ball <simon@...>
Date:   2018-07-19T13:46:52Z

    updated dependencies list to reflect removal of JPA

commit 2f79d6f3f70bdcfd66b757f5751574bb5bc1200c
Author: Simon Elliston Ball <simon@...>
Date:   2018-07-19T10:04:44Z

    Fixed security test for UI settings

commit 22fb74a2db8c4aa7b9425fbaf18f76f07e5e29b7
Author: Simon Elliston Ball <simon@...>
Date:   2018-07-20T12:59:32Z

    Property placeholder is only needed for SSO and LDAP branch

commit ad8d1263ac160098879fa5c0695a623810ef376d
Author: Simon Elliston Ball <simon@...>
Date:   2018-09-12T12:52:44Z

    Merged WebSecurityConfig

----


---

Reply via email to