[
https://issues.apache.org/jira/browse/METRON-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625416#comment-16625416
]
ASF GitHub Bot commented on METRON-1695:
----------------------------------------
Github user anandsubbu commented on the issue:
https://github.com/apache/metron/pull/1207
One thing I am not sure is, whether the topology name i.e.
`metron_pcap_topology` should be fetched from the config or should be hard
coded to 'pcap'. I see that for the enrichment, profiler, indexing etc., we
have hardcoded the topology name and fetch the kafka topic from config. See
[here](https://github.com/apache/metron/blob/master/metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py#L329)
for example. I would like opinions on whether we should follow the same
convention here or should we fetch it from Ambari config.
> Expose pcap properties through Ambari
> -------------------------------------
>
> Key: METRON-1695
> URL: https://issues.apache.org/jira/browse/METRON-1695
> Project: Metron
> Issue Type: Bug
> Reporter: Anand Subramanian
> Assignee: Anand Subramanian
> Priority: Major
>
> Currently, the $METRON_HOME/config/pcap.properties file is hardcoded with the
> defaults. One has to hand edit the file before deploying the PCAP topology.
> These properties should be configurable via Ambari.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
