[GitHub] metron pull request #1213: METRON-1681: Decouple the ParserBolt from the Par...

[merrimanr]

Github user merrimanr commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1213#discussion_r220995913
  
    --- Diff: 
metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/integration/ParserDriver.java
 ---
    @@ -83,49 +86,21 @@ public void close() throws Exception {
         List<byte[]> errors = new ArrayList<>();
     
         public ShimParserBolt(List<byte[]> output) {
    -      super(null
    -          , Collections.singletonMap(
    -              sensorType == null ? config.getSensorTopic() : sensorType,
    -              new ParserComponents(
    -              ReflectionUtils.createInstance(config.getParserClassName()),
    -                  null,
    -                  new WriterHandler(new CollectingWriter(output))
    -              )
    -         )
    -      );
    +      super(null, parserRunner, Collections.singletonMap(sensorType, new 
WriterHandler(new CollectingWriter(output))));
    --- End diff --
    
    Not sure this ShimParserBolt is necessary anymore.


---