Github user nickwallen commented on the issue:

    https://github.com/apache/metron/pull/1213
  
    > @mmiklavc Have you looked over this by chance [2]? The reason I bring 
this up is because it looks like it already addresses a number of the 
points/questions brought up in this PR's discussion. For example, there's a 
strategy for handling successful messages as well as error results [3]. If 
we're going through the effort of refactoring, it's probably worth our while to 
match the other idioms to some degree. It just makes continued maintenance that 
much easier going forward.
    
    Are you making the case for returning a `List` here then?  Sounds like 
you're thinking along these lines?
    ```
    ParserRunner {
       List<ParserResult> execute(...);
    } 
    ```
    
    That would be similar to the unified enrichment work that you linked to in 
your comment.
    ```
    ParallelEnricher {
      EnrichmentResult apply(...);
    }
    ```


---

Reply via email to