[
https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637512#comment-16637512
]
ASF GitHub Bot commented on METRON-1681:
----------------------------------------
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1213
I just pushed a commit out based on some feedback from Nick:
- The stellar context is now passed into the ParserRunner abstraction as a
dependency. I imagine different environments will require different Stellar
initialization strategies so this made sense to me. I also like it because it
makes the abstraction simpler.
- Changed ParserRunner to an interface with a single implementation. I
could change this to ParserRunnerStrategy in case we think we might want to use
that pattern in the future. Then all that would be missing is a ParserContext
class (and possibly a ParserRunnerStrategies enum) which we could add now or
when we need it.
> Decouple the ParserBolt from the Parse execution logic
> ------------------------------------------------------
>
> Key: METRON-1681
> URL: https://issues.apache.org/jira/browse/METRON-1681
> Project: Metron
> Issue Type: Improvement
> Reporter: Justin Leet
> Priority: Major
>
> Per discussion on https://github.com/apache/metron/pull/1099, there are
> concerns about the ParserBolt needed some refactoring. The discussion didn't
> hold the PR up, but it was generally agreed that we should decouple some of
> the initialization and execution logic.
> This also aids us in integrating with other systems such as NiFi or Spark.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
