[
https://issues.apache.org/jira/browse/METRON-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643506#comment-16643506
]
ASF GitHub Bot commented on METRON-1809:
----------------------------------------
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/1229#discussion_r223724471
--- Diff: metron-analytics/metron-profiler-spark/README.md ---
@@ -265,6 +290,18 @@ The path to the input data read by the Batch Profiler.
The format of the input data read by the Batch Profiler.
+### `profiler.batch.input.reader`
--- End diff --
This feels somewhat unnecessary as a parameter.
Why could we just keep `profiler.batch.input.format` and then drop this?
We can determine reader based on the format (COLUMNAR if ORC/Parquet, TEXT
else). If we add other formats in the future, we'd still know right which
reader to pull right?
> Support Column Oriented Input with Batch Profiler
> -------------------------------------------------
>
> Key: METRON-1809
> URL: https://issues.apache.org/jira/browse/METRON-1809
> Project: Metron
> Issue Type: Bug
> Reporter: Nick Allen
> Assignee: Nick Allen
> Priority: Major
>
> The Batch Profiler currently only accepts input formats that can be directly
> serialized to JSON. This should be enhanced to accept a wider variety of
> input formats.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
