[
https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644076#comment-16644076
]
ASF GitHub Bot commented on METRON-1681:
----------------------------------------
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/1213#discussion_r223855883
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/ParserRunner.java
---
@@ -18,20 +18,17 @@
package org.apache.metron.parsers;
import org.apache.metron.common.configuration.ParserConfigurations;
-import org.apache.metron.common.error.MetronError;
import org.apache.metron.common.message.metadata.RawMessage;
import org.apache.metron.stellar.dsl.Context;
+import java.util.List;
import java.util.Set;
-import java.util.function.Consumer;
import java.util.function.Supplier;
public interface ParserRunner {
Set<String> getSensorTypes();
- void setOnSuccess(Consumer<ParserResult> onSuccess);
- void setOnError(Consumer<MetronError> onError);
void init(Supplier<ParserConfigurations> parserConfigSupplier, Context
stellarContext);
- void execute(String sensorType, RawMessage rawMessage,
ParserConfigurations parserConfigurations);
+ List<ParserResult> execute(String sensorType, RawMessage rawMessage,
ParserConfigurations parserConfigurations);
--- End diff --
Groovy
> Decouple the ParserBolt from the Parse execution logic
> ------------------------------------------------------
>
> Key: METRON-1681
> URL: https://issues.apache.org/jira/browse/METRON-1681
> Project: Metron
> Issue Type: Improvement
> Reporter: Justin Leet
> Priority: Major
>
> Per discussion on https://github.com/apache/metron/pull/1099, there are
> concerns about the ParserBolt needed some refactoring. The discussion didn't
> hold the PR up, but it was generally agreed that we should decouple some of
> the initialization and execution logic.
> This also aids us in integrating with other systems such as NiFi or Spark.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
