[
https://issues.apache.org/jira/browse/METRON-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645106#comment-16645106
]
ASF GitHub Bot commented on METRON-1816:
----------------------------------------
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/1233
METRON-1816: Date format Stellar function
## Contributor Comments
This PR adds a Stellar function that wraps the Java SimpleDateFormat class.
The first argument is a date format string and is required. The second
argument is epoch time and is optional (defaults to current time). The third
argument is a timezone and is also option (default time zone of the environment
is used if missing).
### Testing
This has been tested in full dev:
1. Spin up full dev and launch the Stellar REPL. The `DATE_FORMAT`
function should be available:
```
Stellar, Go!
Functions are loading lazily in the background and will be unavailable
until loaded fully.
{}
[Stellar]>>> %functions DATE
DATE_FORMAT, IS_DATE
```
2. Create a variable and set it to an epoch time:
```
[Stellar]>>> epoch := 1472131630748L
1472131630748
```
3. Use the `DATE_FORMAT` function to format the value in the epoch field
created in the previous step. The result should be a correctly formatted date
that matches the format string, epoch time and timezone:
```
[Stellar]>>> DATE_FORMAT('EEE MMM dd yyyy hh:mm:ss zzz', epoch, 'EST')
Thu Aug 25 2016 08:27:10 EST
```
4. Format the date using the default timezone. The result should match the
default timezone of your environment:
```
[Stellar]>>> DATE_FORMAT('EEE MMM dd yyyy hh:mm:ss zzzz', epoch)
Thu Aug 25 2016 01:27:10 Coordinated Universal Time
```
5. Format the date using the current time:
```
[Stellar]>>> DATE_FORMAT('EEE MMM dd yyyy hh:mm:ss zzz', 'GMT')
Tue Oct 09 2018 10:13:24 GMT
```
6. Format the date using the current time and default time zone:
```
[Stellar]>>> DATE_FORMAT('EEE MMM dd yyyy hh:mm:ss zzzz')
Tue Oct 09 2018 10:12:54 Coordinated Universal Time
```
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1816
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1233.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1233
----
commit 6db3f7dda16ab141af5d342eaa240f61a0e62fd9
Author: merrimanr <merrimanr@...>
Date: 2018-10-10T14:47:10Z
initial commit
commit 1fa9cb9f966d5d88070e4eb75c45aa939d4859b3
Author: merrimanr <merrimanr@...>
Date: 2018-10-10T15:01:22Z
fixed test
----
> Date format Stellar function
> ----------------------------
>
> Key: METRON-1816
> URL: https://issues.apache.org/jira/browse/METRON-1816
> Project: Metron
> Issue Type: Improvement
> Reporter: Ryan Merriman
> Priority: Major
>
> It would be useful to have a Stellar function that exposes the Java
> SimpleDateFormat capability. This will allow us to correctly format date
> fields for storage platforms that require a specific date format (Solr for
> example).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
