[
https://issues.apache.org/jira/browse/METRON-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645470#comment-16645470
]
ASF GitHub Bot commented on METRON-1818:
----------------------------------------
GitHub user JonZeolla opened a pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/11
METRON-1818: Remove config_files from bro-pkg.meta
Remove the `config_files` line from `bro-pkg.meta`, as it is [not
necessary](https://bro-package-manager.readthedocs.io/en/stable/package.html?highlight=bro-pkg.meta#config-files-field)
based on the fact our script primarily focuses on having the user redef a
config, as opposed to changing the scripts we provide themselves.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JonZeolla/metron-bro-plugin-kafka METRON-1818
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron-bro-plugin-kafka/pull/11.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11
----
commit 37f5a265e770567d016b87fa351d76e96e4cd0bd
Author: Jon Zeolla <zeolla@...>
Date: 2018-10-10T19:47:46Z
Metron-1818: Remove config_files from bro-pkg.meta
----
> Remove config_files from bro-pkg.meta
> -------------------------------------
>
> Key: METRON-1818
> URL: https://issues.apache.org/jira/browse/METRON-1818
> Project: Metron
> Issue Type: Task
> Reporter: Jon Zeolla
> Assignee: Jon Zeolla
> Priority: Minor
>
> Currently,config_files is set to scripts/init.bro but really all of our
> configs are meant to be redeffable, so this is not necessary.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
