[
https://issues.apache.org/jira/browse/METRON-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646766#comment-16646766
]
ASF GitHub Bot commented on METRON-1820:
----------------------------------------
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1234#discussion_r224528495
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/syslog/Syslog5424Parser.java
---
@@ -61,16 +67,37 @@ public void configure(Map<String, Object> config) {
public void init() {
}
- @Override
@SuppressWarnings("unchecked")
+ @Override
public List<JSONObject> parse(byte[] rawMessage) {
+ Optional<MessageParserResult<JSONObject>> resultOptional =
parseOptionalResult(rawMessage);
--- End diff --
I'm open to a different approach, I could throw a notimplementedexception
or something.
> Update to new Simple-Syslog-5424 version to support error handling
> ------------------------------------------------------------------
>
> Key: METRON-1820
> URL: https://issues.apache.org/jira/browse/METRON-1820
> Project: Metron
> Issue Type: Sub-task
> Reporter: Otto Fowler
> Assignee: Otto Fowler
> Priority: Major
>
> Now that we have an api to support handling per line errors in metron,
> upgrade to the newest version of the simple-syslog5424 library which also
> supports this
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
