[
https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652474#comment-16652474
]
ASF GitHub Bot commented on METRON-1681:
----------------------------------------
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1213
I merged the latest master (which includes
https://github.com/apache/metron/pull/1234) into this PR. I experimented with
moving the methods in MultilineMessageParser back into MessageParser and I
think it turned out well. Makes things clearer and easier to understand in my
opinion (and also made the merge much easier).
What do you think @mmiklavc and @ottobackwards? It reverts some changes in
https://github.com/apache/metron/pull/1234 so I want to get your thoughts and
buy in.
> Decouple the ParserBolt from the Parse execution logic
> ------------------------------------------------------
>
> Key: METRON-1681
> URL: https://issues.apache.org/jira/browse/METRON-1681
> Project: Metron
> Issue Type: Improvement
> Reporter: Justin Leet
> Priority: Major
>
> Per discussion on https://github.com/apache/metron/pull/1099, there are
> concerns about the ParserBolt needed some refactoring. The discussion didn't
> hold the PR up, but it was generally agreed that we should decouple some of
> the initialization and execution logic.
> This also aids us in integrating with other systems such as NiFi or Spark.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
