Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1240#discussion_r226589395
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/table-view/table-view.component.ts
---
@@ -72,15 +72,15 @@ export class TableViewComponent implements OnInit,
OnChanges, OnDestroy {
@Output() onSelectedAlertsChange = new EventEmitter< Alert[]>();
constructor(searchService: SearchService,
- metronDialogBox: MetronDialogBox,
updateService: UpdateService,
metaAlertService: MetaAlertService,
- globalConfigService: GlobalConfigService) {
+ globalConfigService: GlobalConfigService,
+ dialogService: DialogService) {
this.searchService = searchService;
- this.metronDialogBox = metronDialogBox;
this.updateService = updateService;
this.metaAlertService = metaAlertService;
this.globalConfigService = globalConfigService;
+ this.dialogService = dialogService;
--- End diff --
In other places, you haven't assigning injected dialogService to a field
but relying on Angular automagic. I see you tried to stay consistent with the
original constructor impl, but might worth considering to building up a
consistency on an application level.
---
