[
https://issues.apache.org/jira/browse/METRON-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662268#comment-16662268
]
ASF GitHub Bot commented on METRON-1834:
----------------------------------------
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1242#discussion_r227774585
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchColumnMetadataDao.java
---
@@ -64,12 +62,12 @@
/**
* An Elasticsearch administrative client.
*/
- private transient AdminClient adminClient;
+ private transient ElasticsearchClient adminClient;
--- End diff --
Can we call this `client`,`elasticClient`, or `esClient` rather than
retaining the original name `adminClient`, which doesn't make sense any longer?
> Migrate Elasticsearch from TransportClient to new Java REST API
> ---------------------------------------------------------------
>
> Key: METRON-1834
> URL: https://issues.apache.org/jira/browse/METRON-1834
> Project: Metron
> Issue Type: Improvement
> Reporter: Michael Miklavcic
> Assignee: Michael Miklavcic
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
